[10.4 stable] Stop trying to move config from read-only config partition #3629
Conversation
There is some prehistoric code in the onboot script that allows to pass initial hardwaremodel, rebootConfig and restartcounter files via /config partition. However, as this partition became read-only, EVE is no longer able to remove them once applied: move /config/rebootConfig /persist/status mv: cannot remove '/config/rebootConfig': Read-only file system But while the file cannot be removed, mv command will manage to copy its content to /persist. But this means that on every boot the current value in /persist is overwritten with this initial content from /config. This is very dangerous especially for rebootConfig. Device will end up in endless reboot cycle: on every boot it will replace the last applied reboot counter with whatever the initial value was set in /config, which results in counter mismatch wrt. the reboot counter from device config received from the controller. I'm not aware of any practical value of setting initial values of these files through /config, therefore I think this functionality can be completely removed. Signed-off-by: Milan Lenco <[email protected]> (cherry picked from commit c56cdb9)
|
@milan-zededa this has failed eden 3 times (with zfs and ext4 when using tpm). Looking at the last one in https://github.com/lf-edge/eve/actions/runs/7009464560 there is a zedrouter.touch watchdog in the log. Can you take a look? |
Yes, I will investigate. |
|
@milan-zededa once merged, please don't forget to target the 11-stable as well. I did not do that in this PR #3644 due to your previous comment (#3629 (comment)) |
It turned out that the root issue is this fatal error that we see from time to time: I have not seen this with newer runners and it never happens on physical devices it seems (does not appear in production logs), but I will keep an eye on it. |
Backport of #3625 to 10.4
There is some prehistoric code in the onboot script that allows to pass initial hardwaremodel, rebootConfig and restartcounter files via /config partition. However, as this partition became read-only, EVE is no longer able to remove them once applied:
But while the file cannot be removed, mv command will manage to copy its content to /persist. But this means that on every boot the current value in /persist is overwritten with this initial content from /config. This is very dangerous especially for rebootConfig. Device will end up in endless reboot cycle: on every boot it will replace the last applied reboot counter with whatever the initial value was set in /config, which results in counter mismatch wrt. the reboot counter from device config received from the controller.
I'm not aware of any practical value of setting initial values of these files through /config, therefore I think this functionality can be completely removed.
Signed-off-by: Milan Lenco [email protected]
(cherry picked from commit c56cdb9)