Not having IP address with DhcpTypeNone is expected #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVE reports IPAddrNotAvailError even for app-shared ports with DhcpTypeNone (aka DHCP-passthrough). But with such config it is actually expected that there is no IP address assigned and error should not be reported for the port. Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
dhcp-none-err
branch
from
b2b1c0f to
bf0cd49
Compare
uncleDecart
approved these changes
Nov 10, 2023
christoph-zededa
approved these changes
Nov 10, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3576 +/- ##
==========================================
- Coverage 19.47% 19.45% -0.02%
==========================================
Files 231 231
Lines 50211 50211
==========================================
- Hits 9778 9771 -7
- Misses 39716 39724 +8
+ Partials 717 716 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVE reports
IPAddrNotAvailErroreven for app-shared ports withDhcpTypeNone(aka DHCP-passthrough). But with such config it is actually expected that there is no IP address assigned and error should not be reported for the port.