Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypervisor installation fix #3551

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Hypervisor installation fix #3551

merged 1 commit into from
Nov 1, 2023

Conversation

christoph-zededa
Copy link
Contributor 

hypervisor: don't init in install mode

if containerd is initialized during installation the installation will
fail generating an onboarding certificate

@christoph-zededa christoph-zededa force-pushed the hypervisor_installation_fix branch from 80b69a3 to 082a37b Compare October 31, 2023 19:46
@christoph-zededa christoph-zededa force-pushed the hypervisor_installation_fix branch 2 times, most recently from f46bd8c to f1f5ce8 Compare November 1, 2023 12:51
@christoph-zededa
hypervisor: don't init in install mode
8e8e3bf 
if containerd is initialized during installation the installation will
fail generating an onboarding certificate

Signed-off-by: Christoph Ostarek <[email protected]>
@christoph-zededa christoph-zededa force-pushed the hypervisor_installation_fix branch from f1f5ce8 to 8e8e3bf Compare November 1, 2023 12:57
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (8b1f5ba) 19.45% compared to head (8e8e3bf) 19.45%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #3551    +/-   ##
========================================
  Coverage   19.45%   19.45%            
========================================
  Files         230      231     +1     
  Lines       50057    50193   +136     
========================================
+ Hits         9737     9765    +28     
- Misses      39612    39712   +100     
- Partials      708      716     +8
Files Coverage Δ
pkg/pillar/types/domainmgrtypes.go 0.00% <ø> (ø)
pkg/pillar/hypervisor/hypervisor.go 29.16% <0.00%> (-2.18%) ⬇️
pkg/pillar/utils/cloudconfig/cloudconfig.go 57.62% <57.62%> (ø)
pkg/pillar/cmd/domainmgr/domainmgr.go 0.40% <2.38%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christoph-zededa christoph-zededa marked this pull request as ready for review November 1, 2023 13:24
@christoph-zededa christoph-zededa changed the title WIP: Hypervisor installation fix Hypervisor installation fix Nov 1, 2023
eriknordmark
eriknordmark approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark added the stable Should be backported to stable release(s) label Nov 1, 2023
@eriknordmark eriknordmark merged commit 8b66837 into lf-edge:master Nov 1, 2023
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknordmark eriknordmark eriknordmark approved these changes

@rene rene Awaiting requested review from rene rene is a code owner

@rouming rouming Awaiting requested review from rouming rouming is a code owner

@zedi-pramodh zedi-pramodh Awaiting requested review from zedi-pramodh zedi-pramodh is a code owner

Assignees
No one assigned
Labels
stable Should be backported to stable release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christoph-zededa @eriknordmark