ModemManager: enable all available FCC-unlock scripts #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-zededa
force-pushed
the
fcc-unlock
branch
from
219255d to
88ea988
Compare
FCC-locked modems are in disabled state and in low-power mode. ModemManager is not able to use locked modem unless a suitable FCC-unlock procedure is triggered. For some widely used modems, MM provides FCC-unlock scripts. However, in some cases, these scripts are a result of reverse engineering of proprietary unlock utilities. Therefore, these scripts are disabled by default. We already had a situation where FCC unlock was required by an EVE user. We will therefore enable all FCC unlock scripts and then potentially disable only those for which issues will be reported. More info in the documentation that was added. Signed-off-by: Milan Lenco <[email protected]>
When attempt to establish cellular connectivity fails, we want to publish error that helps users to determine the root cause. Context deadline exceeded is rarely usefull. With this commit, mmagent tries to find the real reason behind the timeout, and only returns the original DeadlineExceeded if it cannot do any better. Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
fcc-unlock
branch
from
88ea988 to
fb05a34
Compare
|
Marking as stable because it will be needed in 11.x LTS |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3549 +/- ##
==========================================
- Coverage 19.45% 19.43% -0.02%
==========================================
Files 230 230
Lines 50057 50057
==========================================
- Hits 9737 9729 -8
- Misses 39612 39618 +6
- Partials 708 710 +2 ☔ View full report in Codecov by Sentry. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCC-locked modems are in disabled state and in low-power mode. ModemManager is not able to use locked modem unless a suitable FCC-unlock procedure is triggered. For some widely used modems, MM provides FCC-unlock scripts. However, in some cases, these scripts are a result of reverse engineering of proprietary unlock utilities and may not work correctly. Therefore, these scripts are disabled by default.
We already had a situation where FCC unlock was required by an EVE user. We will therefore enable all FCC unlock scripts and then potentially disable only those for which issues will be reported. More info in the documentation that was added.
Additionally in this PR, there is a small improvement in terms of errors reported for failed connectivity setup. mmagent tries to find more useful reason for failure than
context.DeadlineExceeded.