GitHub Actions: use correct tag in assets.yml #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pass github.ref which have format refs/tags/%tag%. We can use this format to download GitHub repository and checkout to specific branch, however this format is not applicable to docker pull and rest of the steps. Therefore we set up TAG environment variable in %tag% format which is used in all steps after checking out and is derived from git tag. Signed-off-by: Pavel Abramov <[email protected]>
eriknordmark
approved these changes
Oct 26, 2023
|
Yes, it'll use master version |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3529 +/- ##
=======================================
Coverage 20.51% 20.51%
=======================================
Files 208 208
Lines 45381 45381
=======================================
+ Hits 9309 9310 +1
Misses 35389 35389
+ Partials 683 682 -1 ☔ View full report in Codecov by Sentry. |
uncleDecart
added a commit
to uncleDecart/eve
that referenced
this pull request
Oct 26, 2023
Following lf-edge#3529 this commit fixes publishing step. TAG variable should not be quoted. We remove tag environment variable and use TAG since it's already present. Signed-off-by: Pavel Abramov <[email protected]>
eriknordmark
pushed a commit
that referenced
this pull request
Oct 26, 2023
Following #3529 this commit fixes publishing step. TAG variable should not be quoted. We remove tag environment variable and use TAG since it's already present. Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
to uncleDecart/eve
that referenced
this pull request
Oct 26, 2023
Following lf-edge#3529 this commit fixes publishing step. TAG variable should not be quoted. We remove tag environment variable and use TAG since it's already present. Signed-off-by: Pavel Abramov <[email protected]>
eriknordmark
pushed a commit
that referenced
this pull request
Oct 27, 2023
Following #3529 this commit fixes publishing step. TAG variable should not be quoted. We remove tag environment variable and use TAG since it's already present. Signed-off-by: Pavel Abramov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass github.ref which have format refs/tags/%tag%. We can use this format to download GitHub repository and checkout to specific branch, however this format is not applicable to docker pull and rest of the steps. Therefore we set up TAG environment variable in %tag% format which is used in all steps after checking out and is derived from git tag.