Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move types not used by zedrouter out of zedroutertypes.go #3513

Merged
merged 1 commit into from
Oct 24, 2023

Move types not used by zedrouter out of zedroutertypes.go

f70d710
Select commit
Loading
Failed to load commit list.
Merged

Move types not used by zedrouter out of zedroutertypes.go #3513

Move types not used by zedrouter out of zedroutertypes.go
f70d710
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 23, 2023 in 0s

20.50% (-0.01%) compared to 196c3cf

View this Pull Request on Codecov

20.50% (-0.01%) compared to 196c3cf

Details

Codecov Report

Attention: 889 lines in your changes are missing coverage. Please review.

Comparison is base (196c3cf) 20.51% compared to head (f70d710) 20.50%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
- Coverage   20.51%   20.50%   -0.01%     
==========================================
  Files         203      209       +6     
  Lines       45430    45391      -39     
==========================================
- Hits         9319     9308      -11     
+ Misses      35430    35401      -29     
- Partials      681      682       +1     
Files Coverage Δ
pkg/pillar/dpcmanager/dns.go 62.17% <100.00%> (ø)
pkg/pillar/dpcreconciler/linux.go 74.94% <100.00%> (ø)
pkg/pillar/nireconciler/linux_config.go 90.13% <ø> (ø)
pkg/pillar/cmd/zedagent/reportinfo.go 0.00% <0.00%> (ø)
pkg/pillar/cmd/diag/diag.go 0.00% <0.00%> (ø)
pkg/pillar/types/errors.go 0.00% <0.00%> (ø)
pkg/pillar/dpcreconciler/genericitems/dhcpcd.go 19.26% <50.00%> (ø)
pkg/pillar/cmd/zedagent/parseconfig.go 23.86% <33.33%> (ø)
pkg/pillar/types/onboardingtypes.go 0.00% <0.00%> (ø)
pkg/pillar/types/cachedresolvedip.go 0.00% <0.00%> (ø)
... and 4 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.