-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to trigger eden workflow based on condition #3450
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| --- | ||
| name: Eden | ||
| on: # yamllint disable-line rule:truthy | ||
| name: lf-edge/eden Test suite | ||
|
|
||
| # yamllint disable-line rule:truthy | ||
| on: | ||
| push: | ||
| branches: | ||
| - "master" | ||
|
|
@@ -15,141 +17,25 @@ on: # yamllint disable-line rule:truthy | |
| - 'docs/**' | ||
| - 'pkg/pillar/docs/**' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| integration: | ||
| name: Integration test (tpm=${{ matrix.tpm }};${{ matrix.fs }}) | ||
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| tpm: ["true", "false"] | ||
| fs: ["zfs", "ext4"] | ||
| if: ${{ github.event.review.state == 'approved' || github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags') }} | ||
| steps: | ||
| - name: Check | ||
| run: | | ||
| for addr in $(ip addr list|sed -En -e 's/.*inet ([0-9.]+).*/\1/p') | ||
| do | ||
| if echo "$addr" | grep -q -E "10.11.(12|13).[0-9]+"; then | ||
| echo "$addr overlaps with test"; exit 1 | ||
| fi | ||
| done | ||
| sudo df -h | ||
| sudo swapoff -a | ||
| sudo free | ||
| - name: setup | ||
| run: | | ||
| sudo add-apt-repository ppa:stefanberger/swtpm-jammy | ||
| sudo apt install -y qemu-utils qemu-system-x86 jq swtpm | ||
| - name: get eve | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| path: 'eve' | ||
| - name: prepare eden | ||
| run: | | ||
| if [ -f ${{ github.workspace }}/eve/tests/eden/eden-version ]; then | ||
| EDEN_VERSION=$(cat ${{ github.workspace }}/eve/tests/eden/eden-version) | ||
| else | ||
| EDEN_VERSION=lfedge/eden:0.8.0 | ||
| fi | ||
| docker run -v $PWD:/out $EDEN_VERSION cp -a /eden/. /out/ | ||
| sudo chown -R $(whoami) . | ||
| ./eden config add default | ||
| - name: fetch or build eve | ||
| env: | ||
| TAG: pr${{ github.event.pull_request.number }} | ||
| CACHE: evebuild/danger | ||
| run: | | ||
| BUILD=true | ||
| if docker pull "$CACHE:$TAG-kvm"; then | ||
| # we should check version of pulled image | ||
| # since in case of build in progress we do not want to test | ||
| # old version pushed to docker hub | ||
| # version logic must be aligned with PR build workflow | ||
| COMMIT_ID=$(git --git-dir ./eve/.git describe --abbrev=8 --always) | ||
| EXPECTED_VERSION="0.0.0-$TAG-$COMMIT_ID-kvm-amd64" | ||
| PULLED_VERSION=$(docker run --rm "$CACHE:$TAG-kvm" version) | ||
| if [ "$PULLED_VERSION" = "$EXPECTED_VERSION" ]; then | ||
| docker tag "$CACHE:$TAG-kvm" "lfedge/eve:$TAG-kvm" | ||
| docker tag "$CACHE:$TAG-kvm" "lfedge/eve:$TAG-kvm-amd64" | ||
| BUILD=false | ||
| else | ||
| docker rmi --force "$CACHE:$TAG-kvm" | ||
| fi | ||
| fi | ||
| if [ "$BUILD" = "true" ]; then | ||
| make -C eve V=1 PRUNE=1 pkgs | ||
| make -C eve V=1 ROOTFS_VERSION="$TAG" eve | ||
| IMAGES="$(docker images -f reference="lfedge/eve-*" -q)" | ||
| IMAGES="$IMAGES $(docker images -f reference="eve-build-*" -q)" | ||
| IMAGES="$IMAGES $(docker images -f reference="golang" -q)" | ||
| IMAGES="$IMAGES $(docker images -f dangling=true -q)" | ||
| docker rmi -f $IMAGES||echo "skip conflicts" | ||
| rm -rf ~/.linuxkit | ||
| fi | ||
| - name: set debug log level | ||
| if: contains(github.event.review.body, '#eden-debug') | ||
| run: | | ||
| ./eden config set default --key=eve.log-level --value=debug | ||
| ./eden config set default --key=eve.adam-log-level --value=debug | ||
| - name: run | ||
| env: | ||
| TAG: pr${{ github.event.pull_request.number }} | ||
| run: | | ||
| ./eden config set default --key eve.tag --value="$TAG" | ||
| ./eden config set default --key=eve.accel --value=false | ||
| ./eden config set default --key=eve.tpm --value=${{ matrix.tpm }} | ||
| ./eden config set default --key=eve.cpu --value=2 | ||
| ./eden config set default --key=eden.tests --value=${{ github.workspace }}/eve/tests/eden | ||
| EDITOR=cat ./eden config edit default | ||
| - name: setup-ext4 | ||
| if: matrix.fs == 'ext4' | ||
| run: ./eden setup -v debug | ||
| - name: setup-zfs | ||
| if: matrix.fs == 'zfs' | ||
| run: | | ||
| ./eden config set default --key=eve.disks --value=4 | ||
| ./eden config set default --key=eve.disk --value=4096 | ||
| ./eden setup -v debug --grub-options='set_global dom0_extra_args "$dom0_extra_args eve_install_zfs_with_raid_level "' | ||
| - name: run | ||
| run: EDEN_TEST_STOP=n ./eden test ${{ github.workspace }}/eve/tests/eden/workflow -v debug | ||
| - name: Collect logs | ||
| if: ${{ always() }} | ||
| run: | | ||
| ./eden log --format json > trace.log || echo "no log" | ||
| ./eden info --format json > info.log || echo "no info" | ||
| ./eden metric --format json > metric.log || echo "no metric" | ||
| ./eden netstat --format json > netstat.log || echo "no netstat" | ||
| cp dist/default-eve.log console.log || echo "no device log" | ||
| docker logs eden_adam > adam.log 2>&1 || echo "no adam log" | ||
| - name: Log counting | ||
| if: ${{ always() }} | ||
| run: | | ||
| echo "::group::Total errors" | ||
| echo "$(jq '.severity' trace.log|grep err|wc -l)" | ||
| echo "::endgroup::" | ||
| echo "::group::Errors by source" | ||
| echo "errors by source: $(jq -s 'map(select(.severity|contains("err")))|group_by(.source)|map({"source": .[0].source, "total":length})|sort_by(.total)|reverse[]' trace.log)" | ||
| echo "::endgroup::" | ||
| echo "::group::Error log content duplicates" | ||
| echo "$(jq -s 'map(select(.severity | contains("err")))|group_by(.content)|map(select(length>1))' trace.log)" | ||
| echo "::endgroup::" | ||
| echo "::group::Error log function filename duplicates" | ||
| echo "$(jq -s 'map(select(.severity | contains("err")))|group_by(.filename)|map(select(length>10))|map({"source": .[0].source, "filename": .[0].filename, "function": .[0].function, "content": [.[].content], "total":length})|sort_by(.total)| reverse[]' trace.log)" | ||
| echo "::endgroup::" | ||
| echo "::group::Segfaults" | ||
| echo "$(jq -s 'map(select(.content | contains("segfault at")))' trace.log)"|tee segfaults.log | ||
| [ "$(jq length segfaults.log)" -gt 0 ] && echo "::warning::segfaults found, you can see them in Log counting->Segfaults section" | ||
| echo "::endgroup::" | ||
| - name: Store raw test results | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: eden-report-tpm-${{ matrix.tpm }}-${{ matrix.fs }} | ||
| path: | | ||
| ${{ github.workspace }}/trace.log | ||
| ${{ github.workspace }}/info.log | ||
| ${{ github.workspace }}/metric.log | ||
| ${{ github.workspace }}/netstat.log | ||
| ${{ github.workspace }}/console.log | ||
| ${{ github.workspace }}/adam.log | ||
| test_suite_pr: | ||
| if: github.event.review.state == 'approved' | ||
| uses: lf-edge/eden/.github/workflows/[email protected] | ||
| with: | ||
| eve_image: "evebuild/danger:pr${{ github.event.pull_request.number }}" | ||
|
|
||
| test_suite_master: | ||
| if: github.ref == 'refs/heads/master' | ||
| uses: lf-edge/eden/.github/workflows/[email protected] | ||
| with: | ||
| eve_image: "lfedge/eve:snapshot" | ||
|
|
||
| test_suite_tag: | ||
| if: startsWith(github.ref, 'refs/tags') | ||
| uses: lf-edge/eden/.github/workflows/[email protected] | ||
| with: | ||
| eve_image: "lfedge/eve:${{ github.ref_name }}" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| --- | ||
| name: Eden | ||
| # yamllint disable-line rule:comments, rule:truthy | ||
| on: | ||
| workflow_dispatch | ||
|
|
||
| # yamllint disable-line rule:comments | ||
| #on: | ||
| # push: | ||
| # branches: | ||
| # - "master" | ||
| # - "[0-9]+.[0-9]+" | ||
| # - "[0-9]+.[0-9]+-stable" | ||
| # paths-ignore: | ||
| # - 'docs/**' | ||
| # - 'pkg/pillar/docs/**' | ||
| # pull_request_review: | ||
| # types: [submitted] | ||
| # paths-ignore: | ||
| # - 'docs/**' | ||
| # - 'pkg/pillar/docs/**' | ||
|
|
||
| jobs: | ||
| integration: | ||
| name: Integration test (tpm=${{ matrix.tpm }};${{ matrix.fs }}) | ||
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| tpm: ["true", "false"] | ||
| fs: ["zfs", "ext4"] | ||
| if: ${{ github.event.review.state == 'approved' || github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags') }} | ||
| steps: | ||
| - name: Check | ||
| run: | | ||
| for addr in $(ip addr list|sed -En -e 's/.*inet ([0-9.]+).*/\1/p') | ||
| do | ||
| if echo "$addr" | grep -q -E "10.11.(12|13).[0-9]+"; then | ||
| echo "$addr overlaps with test"; exit 1 | ||
| fi | ||
| done | ||
| sudo df -h | ||
| sudo swapoff -a | ||
| sudo free | ||
| - name: setup | ||
| run: | | ||
| sudo add-apt-repository ppa:stefanberger/swtpm-jammy | ||
| sudo apt install -y qemu-utils qemu-system-x86 jq swtpm | ||
| - name: get eve | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| path: 'eve' | ||
| - name: prepare eden | ||
| run: | | ||
| if [ -f ${{ github.workspace }}/eve/tests/eden/eden-version ]; then | ||
| EDEN_VERSION=$(cat ${{ github.workspace }}/eve/tests/eden/eden-version) | ||
| else | ||
| EDEN_VERSION=lfedge/eden:0.8.0 | ||
| fi | ||
| docker run -v $PWD:/out $EDEN_VERSION cp -a /eden/. /out/ | ||
| sudo chown -R $(whoami) . | ||
| ./eden config add default | ||
| - name: fetch or build eve | ||
| env: | ||
| TAG: pr${{ github.event.pull_request.number }} | ||
| CACHE: evebuild/danger | ||
| run: | | ||
| BUILD=true | ||
| if docker pull "$CACHE:$TAG-kvm"; then | ||
| # we should check version of pulled image | ||
| # since in case of build in progress we do not want to test | ||
| # old version pushed to docker hub | ||
| # version logic must be aligned with PR build workflow | ||
| COMMIT_ID=$(git --git-dir ./eve/.git describe --abbrev=8 --always) | ||
| EXPECTED_VERSION="0.0.0-$TAG-$COMMIT_ID-kvm-amd64" | ||
| PULLED_VERSION=$(docker run --rm "$CACHE:$TAG-kvm" version) | ||
| if [ "$PULLED_VERSION" = "$EXPECTED_VERSION" ]; then | ||
| docker tag "$CACHE:$TAG-kvm" "lfedge/eve:$TAG-kvm" | ||
| docker tag "$CACHE:$TAG-kvm" "lfedge/eve:$TAG-kvm-amd64" | ||
| BUILD=false | ||
| else | ||
| docker rmi --force "$CACHE:$TAG-kvm" | ||
| fi | ||
| fi | ||
| if [ "$BUILD" = "true" ]; then | ||
| make -C eve V=1 PRUNE=1 pkgs | ||
| make -C eve V=1 ROOTFS_VERSION="$TAG" eve | ||
| IMAGES="$(docker images -f reference="lfedge/eve-*" -q)" | ||
| IMAGES="$IMAGES $(docker images -f reference="eve-build-*" -q)" | ||
| IMAGES="$IMAGES $(docker images -f reference="golang" -q)" | ||
| IMAGES="$IMAGES $(docker images -f dangling=true -q)" | ||
| docker rmi -f $IMAGES||echo "skip conflicts" | ||
| rm -rf ~/.linuxkit | ||
| fi | ||
| - name: set debug log level | ||
| if: contains(github.event.review.body, '#eden-debug') | ||
| run: | | ||
| ./eden config set default --key=eve.log-level --value=debug | ||
| ./eden config set default --key=eve.adam-log-level --value=debug | ||
| - name: run | ||
| env: | ||
| TAG: pr${{ github.event.pull_request.number }} | ||
| run: | | ||
| ./eden config set default --key eve.tag --value="$TAG" | ||
| ./eden config set default --key=eve.accel --value=false | ||
| ./eden config set default --key=eve.tpm --value=${{ matrix.tpm }} | ||
| ./eden config set default --key=eve.cpu --value=2 | ||
| ./eden config set default --key=eden.tests --value=${{ github.workspace }}/eve/tests/eden | ||
| EDITOR=cat ./eden config edit default | ||
| - name: setup-ext4 | ||
| if: matrix.fs == 'ext4' | ||
| run: ./eden setup -v debug | ||
| - name: setup-zfs | ||
| if: matrix.fs == 'zfs' | ||
| run: | | ||
| ./eden config set default --key=eve.disks --value=4 | ||
| ./eden config set default --key=eve.disk --value=4096 | ||
| ./eden setup -v debug --grub-options='set_global dom0_extra_args "$dom0_extra_args eve_install_zfs_with_raid_level "' | ||
| - name: run | ||
| run: EDEN_TEST_STOP=n ./eden test ${{ github.workspace }}/eve/tests/eden/workflow -v debug | ||
| - name: Collect logs | ||
| if: ${{ always() }} | ||
| run: | | ||
| ./eden log --format json > trace.log || echo "no log" | ||
| ./eden info --format json > info.log || echo "no info" | ||
| ./eden metric --format json > metric.log || echo "no metric" | ||
| ./eden netstat --format json > netstat.log || echo "no netstat" | ||
| cp dist/default-eve.log console.log || echo "no device log" | ||
| docker logs eden_adam > adam.log 2>&1 || echo "no adam log" | ||
| - name: Log counting | ||
| if: ${{ always() }} | ||
| run: | | ||
| echo "::group::Total errors" | ||
| echo "$(jq '.severity' trace.log|grep err|wc -l)" | ||
| echo "::endgroup::" | ||
| echo "::group::Errors by source" | ||
| echo "errors by source: $(jq -s 'map(select(.severity|contains("err")))|group_by(.source)|map({"source": .[0].source, "total":length})|sort_by(.total)|reverse[]' trace.log)" | ||
| echo "::endgroup::" | ||
| echo "::group::Error log content duplicates" | ||
| echo "$(jq -s 'map(select(.severity | contains("err")))|group_by(.content)|map(select(length>1))' trace.log)" | ||
| echo "::endgroup::" | ||
| echo "::group::Error log function filename duplicates" | ||
| echo "$(jq -s 'map(select(.severity | contains("err")))|group_by(.filename)|map(select(length>10))|map({"source": .[0].source, "filename": .[0].filename, "function": .[0].function, "content": [.[].content], "total":length})|sort_by(.total)| reverse[]' trace.log)" | ||
| echo "::endgroup::" | ||
| echo "::group::Segfaults" | ||
| echo "$(jq -s 'map(select(.content | contains("segfault at")))' trace.log)"|tee segfaults.log | ||
| [ "$(jq length segfaults.log)" -gt 0 ] && echo "::warning::segfaults found, you can see them in Log counting->Segfaults section" | ||
| echo "::endgroup::" | ||
| - name: Store raw test results | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: eden-report-tpm-${{ matrix.tpm }}-${{ matrix.fs }} | ||
| path: | | ||
| ${{ github.workspace }}/trace.log | ||
| ${{ github.workspace }}/info.log | ||
| ${{ github.workspace }}/metric.log | ||
| ${{ github.workspace }}/netstat.log | ||
| ${{ github.workspace }}/console.log | ||
| ${{ github.workspace }}/adam.log | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that this workflow works in case of manual
workflow_dispatchrun?I am not sure that we will pass the check
if: ${{ github.event.review.state == 'approved' || github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags') }}. It looks like we will be able to test only the head of master.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if: ${{ github.event.review.state == 'approved' || github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags') }}The plan is to test the WF on master. I have added the
workflow_dispatchonly for testing needs and will remove it soon.