Skip to content

Commit

Permalink
pillar/zedagent: Revert snapshot capability due to misleading support…
Browse files Browse the repository at this point in the history
… indication.

Rolling back the reported capability from CAPABILITY_VOLUME_SNAPSHOTS to
CAPABILITY_START_DELAY_IN_SECONDS in ReportDeviceInfo.

This change addresses the inconsistency where the UI indicated snapshot support
in versions prior to its actual implementation.

Noted that CAPABILITY_EDGEVIEW, which should technically precede, is commented
out in the API proto file.

Signed-off-by: Nikolay Martyanov <[email protected]>
  • Loading branch information
OhmSpectator committed Oct 26, 2023
1 parent 71b4779 commit 7320495
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions pkg/pillar/cmd/zedagent/reportinfo.go
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,7 @@ func PublishDeviceInfoToZedCloud(ctx *zedagentContext, dest destinationBitset) {

ReportDeviceInfo.State = getState(ctx)

// TODO: Enhance capability reporting with a bitmap-like approach for increased granularity.
// We report the snapshot capability despite the fact that we support snapshots only
// for file-based volumes. If a controller tries to make a snapshot of ZFS-based volume
// device returns a runtime error.
ReportDeviceInfo.ApiCapability = info.APICapability_API_CAPABILITY_VOLUME_SNAPSHOTS
ReportDeviceInfo.ApiCapability = info.APICapability_API_CAPABILITY_START_DELAY_IN_SECONDS

// Report if there is a local override of profile
if ctx.getconfigCtx.currentProfile != ctx.getconfigCtx.globalProfile {
Expand Down

0 comments on commit 7320495

Please sign in to comment.