Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dockerfile from checker #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christoph-zededa
Copy link
Contributor

No description provided.

It can be removed as it is now in the eve repository.

Signed-off-by: Christoph Ostarek <[email protected]>
@christoph-zededa christoph-zededa force-pushed the remove_dockerfile-from-checker branch from 93e6efc to 88011bf Compare October 11, 2024 16:55
@deitch
Copy link
Contributor

deitch commented Oct 13, 2024

Why are we moving this out of here and into lf-edge/eve?

@christoph-zededa
Copy link
Contributor Author

Why are we moving this out of here and into lf-edge/eve?

Besides lf-edge/eve#4334 (comment) there are some more reasons:

@deitch
Copy link
Contributor

deitch commented Oct 13, 2024

some more reasons

The eve-build-tools probably should be better known, agreed.

The argument you are making is basically for a monorepo with everything in it. We cannot afford that. Let's say that tomorrow there is a new version of the dockerfile frontend. Do you really need to go through all of the long slow eve CI, and tie up runners, just to update that tool? You might want to once you are sure the tool is ready, but not before that. That is what libraries are about: modularization.

EVE repo is way too big and heavy. We didn't like moving the api out to eve-api repo either, but it was critically necessary.

@christoph-zededa
Copy link
Contributor Author

The argument you are making is basically for a monorepo with everything in it. We cannot afford that.

No everything. F.e. no gcc sources or kernel sources. Also we just added another 4k files for rust ...

Let's say that tomorrow there is a new version of the dockerfile frontend. Do you really need to go through all of the long slow eve CI, and tie up runners, just to update that tool? You might want to once you are sure the tool is ready, but not before that. That is what libraries are about: modularization.

No, that's why I am also working on lf-edge/eve#4202 (slowly working on it though)

Are there any other reasons why we cannot afford that?


Okay, so you are advertising to use a multi-repo strategy, but unfortunately we lack the infrastructure to do so:

  • no sync of GH actions between the repositories
  • no sync of Makefile targets between the repositories (f.e. yetus)
  • manual work to bump up revisions (f.e. eve-api or eve-kernel)
  • no organized way to update all repositories locally like f.e. https://gerrit.googlesource.com/git-repo

@deitch
Copy link
Contributor

deitch commented Oct 13, 2024

We already do use a multi-repo strategy, and a mono-repo, at the same time.

some of it always will be multi-repo: kernel, eve-api, libs. There are solid reasons for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants