Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update go version #830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tdrozdovsky
Copy link
Contributor

@tdrozdovsky tdrozdovsky commented Nov 2, 2024

Description

It is necessary to update:

  • Go to the 1.23 latest version
  • Ubuntu 24.04
  • Some tests
  • Update rand method
  • Remove i386 base image (not supported)

Unfortunately, it all had to be done in one commit, as many changes required verification and successful workflow execution

Also, after applying other 3rd-party component updates, there will be a final review and editing of documentation and comments.

Type of change

  • Code cleanup/refactoring

Test Configuration:

  • OS type & version: Ubuntu 20.04
  • Hardware: x86-64 (e.g., x86-64, arm, arm64)
  • Toolchain: Docker v27.3 & Go v1.23
  • Edge Orchestration Release: v1.2.x

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@boring-cyborg boring-cyborg bot added CI config documentation Improvements or additions to documentation labels Nov 2, 2024
@tdrozdovsky tdrozdovsky changed the title feat: Update go version [WIP] feat: Update go version Nov 2, 2024
Copy link

github-actions bot commented Nov 4, 2024

One business day has passed since the review started. Give priority to reviews as much as possible. 🙏

@boring-cyborg boring-cyborg bot added base code tc Test Coverage update labels Nov 4, 2024
@tdrozdovsky tdrozdovsky force-pushed the upd-go-ver branch 2 times, most recently from ab72a8a to fca57ce Compare November 4, 2024 12:36
@tdrozdovsky tdrozdovsky force-pushed the upd-go-ver branch 5 times, most recently from 32e95fa to 5fef0dd Compare December 19, 2024 18:04
@boring-cyborg boring-cyborg bot added the security Any tasks and issues w.r.t. the security label Dec 19, 2024
@boring-cyborg boring-cyborg bot added the mqtt label Dec 19, 2024
@tdrozdovsky tdrozdovsky force-pushed the upd-go-ver branch 6 times, most recently from ae03c96 to 09feefa Compare December 21, 2024 09:55
@tdrozdovsky tdrozdovsky force-pushed the upd-go-ver branch 20 times, most recently from 64ffe70 to 21d2fa1 Compare December 22, 2024 06:22
Signed-off-by: Taras Drozdovskyi <[email protected]>
@tdrozdovsky tdrozdovsky changed the title [WIP] feat: Update go version feat: Update go version Dec 22, 2024
@tdrozdovsky tdrozdovsky self-assigned this Dec 22, 2024
@tdrozdovsky tdrozdovsky added this to the v1.3.0 milestone Dec 22, 2024
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base code CI config documentation Improvements or additions to documentation mqtt security Any tasks and issues w.r.t. the security tc Test Coverage update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants