Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix scorecards-analysis workflow #757

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

tdrozdovsky
Copy link
Contributor

Description

The analysis system has not been working for a long time https://github.com/lf-edge/edge-home-orchestration-go/actions/workflows/scorecards-analysis.yml
It’s time to fix it

Fixes #754 #755 #756

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • CI system update

Test Configuration:

  • OS type & version: Ubuntu 20.04
  • Hardware: x86-64 (e.g., x86, x86-64, arm, arm64)
  • Toolchain: Docker v20.10 & Go v1.19
  • Edge Orchestration Release: v1.2.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Taras Drozdovskyi <[email protected]>
@tdrozdovsky tdrozdovsky added this to the v1.2.1 milestone Feb 7, 2024
@tdrozdovsky tdrozdovsky self-assigned this Feb 7, 2024
@boring-cyborg boring-cyborg bot added the CI label Feb 7, 2024
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tdrozdovsky tdrozdovsky merged commit 7c74596 into lf-edge:master Feb 7, 2024
14 checks passed
@tdrozdovsky tdrozdovsky deleted the fix-scorecard branch May 3, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants