Revert "Bump golang.org/x/net from 0.8.0 to 0.17.0 in /sdn/vm" #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 55a9d23.
|
@milan-zededa I guess we need to locally try to update it. |
|
@giggsoff can you check? :) |
giggsoff
approved these changes
Oct 23, 2023
|
Can you please sign the commit? |
|
Well, I think we can close it with #904 merged. |
|
@giggsoff can you please reopen it? I don't have permissions to do that |
|
Okay, now it seems to be working with two commits merged from dependabot |
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Oct 23, 2023
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 This commit introduces ref parameter to avoid pulling and building Eden master. Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Oct 24, 2023
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 This commit introduces ref parameter to avoid pulling and building Eden master. Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Oct 24, 2023
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 This commit introduces ref parameter to avoid pulling and building Eden master. Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Oct 25, 2023
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 This commit introduces ref parameter to avoid pulling and building Eden master. Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Nov 7, 2023
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Nov 7, 2023
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
to uncleDecart/eden
that referenced
this pull request
Nov 8, 2023
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <[email protected]>
giggsoff
pushed a commit
that referenced
this pull request
Nov 8, 2023
Following on #910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check #909 for more info Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
deleted the
revert-904-dependabot/go_modules/sdn/vm/golang.org/x/net-0.17.0
branch
europaul
pushed a commit
to europaul/eden
that referenced
this pull request
Feb 7, 2024
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
added a commit
that referenced
this pull request
Feb 7, 2024
Following on #910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check #909 for more info Signed-off-by: Pavel Abramov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #904
Build fails, so we need to investigate what causes it