Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust working directory in collect-info #898

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

giggsoff
Copy link
Collaborator

@giggsoff giggsoff commented Oct 4, 2023

I can see problems in eden_gcp workflow where eden subdirectory does not exist. Let's use input variable to set working-directory aligned with our expectation.

I can see problems in eden_gcp workflow where eden subdirectory does
not exist. Let's use input variable to set working-directory aligned
with our expectation.

Signed-off-by: Petr Fedchenkov <[email protected]>
@giggsoff giggsoff requested a review from uncleDecart as a code owner October 4, 2023 13:58
Copy link
Contributor

@milan-zededa milan-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this

Copy link
Member

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot @giggsoff ! 🎉

@uncleDecart uncleDecart merged commit a963693 into lf-edge:master Oct 4, 2023
6 of 9 checks passed
uncleDecart added a commit to uncleDecart/eden that referenced this pull request Oct 5, 2023
Following lf-edge#898 we adjust collect-info working directory in
new tests

Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart added a commit to uncleDecart/eden that referenced this pull request Oct 6, 2023
Following lf-edge#898 we adjust collect-info working directory in
new tests

Signed-off-by: Pavel Abramov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants