GitHub Actions: use report_name instead of variables in publish-logs #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-zededa
reviewed
Oct 4, 2023
| @@ -34,6 +34,7 @@ runs: | |||
| if: always() | |||
| uses: ./eden/.github/actions/publish-logs | |||
| with: | |||
| report_name: eden-report-${{ inputs.suite }}-tpm-${{ inputs.tpm_enabled }}-${{ inputs.file_system }} | |||
| file_system: ${{ inputs.file_system }} | |||
There was a problem hiding this comment.
file_system and tpm_enabled can be removed from "with"
Previous implementation did not use test suite name in publishing logs, therefore for 11 different workflows we got only 4 artifacts, new implimentation uses report_name parameter in publish-logs action which makes it more flexible to set up any report name user wants and makes it more clear how it forms in `run-eden-test` action. And, of course, it adds test suite name now Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
force-pushed
the
fix-publish-logs
branch
from
17725dc to
2cffca5
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation did not use test suite name in publishing logs, therefore for 11 different workflows we got only 4 artifacts, new implimentation uses report_name parameter in publish-logs action which makes it more flexible to set up any report name user wants and makes it more clear how it forms in
run-eden-testaction. And, of course, it adds test suite name nowcc: @milan-zededa @yash-zededa
Please approve: @deitch @eriknordmark