run tests from docker image directly

[deitch]

This adds tests to update the image from an OCI image directly.

It uses version 6.1.0. I checked, and that version does, indeed, have the right labels to work.

A few open questions:

1. Did I do this correctly? Added a test line to tests/update_eve_image/eden.update_eve_image.tests.txt, and then the test in tests/update_eve_image/testdata/update_eve_image_oci.txt
2. Should we be resetting the image back to the base (pre-update) in testdata/update_eve_image.txt before running the next test? Should we in testdata/update_eve_image_oci.txt? If so, how do we do it?

[deitch]

Fixes #539

[giggsoff]

Hi, @deitch
Yes, you done it correctly.

Seems, we should return to the tested (pre-update) version somehow. There are several reasons for it:

• We want to test pre-update version of EVE
• We want the test not to affect the following

But for now I cannot find how to return back to pre-update version. After update we have testing time, we can return to previous version automatically in the case of crash. But we cannot fire reboot in this time. Also, I tried to reset config to the empty one with ./eden eve reset and that didn't work for me either.

[deitch]

So we agree we should do it, but we don't know how :-)

@rvs got ideas?

[rvs]

What exactly is your question @deitch ?

[deitch]

Nothing any more @rvs ; @giggsoff wanted to have a way to reset the image after an image update, but wasn't sure how to do it. But I think he figured it out, see #558. Once he has that merged in, I will be able to rebase this one. If it passes, we can merge it in.

[deitch]

Now that #558 is merged in, I rebased this on that, added the reset, and will let this run.

[deitch]

This looks clean now. Put a review on @giggsoff please

[giggsoff]

Hi, @deitch. Please add your test into workflow after lines

eden/tests/workflow/eden.workflow.tests.txt

Lines 122 to 123 in 00efce0

	/bin/echo Eden base OS update (34/{{$tests}})
	eden.escript.test -testdata ../update_eve_image/testdata/ -test.run TestEdenScripts/update_eve_image_http

Also, you should change version inside your test. For now, version 6.1.0 is the version of builded image in Eden by default

eden/pkg/defaults/defaults.go

Line 51 in 00efce0

DefaultEVETag = "6.1.0" //DefaultEVETag tag for EVE image

[deitch]

Sure thing.

[deitch]

Done @giggsoff take another look at it

[deitch]

The tests failed, I messed up the oci:// URL. Just fixed it and pushed again.

[deitch]

Looks like it passed CI. Huzzah! Back at you @giggsoff

[giggsoff]

Actually it is discussible, but, in case of subsequent revert, we should wait for active (not inprogress or active) state here. You can decrease testing time to do it faster like inside

eden/tests/update_eve_image/testdata/update_eve_image_http.txt

Line 23 in 00efce0

eden controller edge-node update --config timer.test.baseimage.update=30

WDYT, @deitch?

[deitch]

I think I am ok either way. Whatever you want, either take this as is, or tell me you prefer with just active and I will change it

[giggsoff]

I suggest you to change to active and modify testing time. Without it we just move our waiting onto nested script (revert_eve_image_update).

[deitch]

Done.

[giggsoff]

Thank you!

[giggsoff]

Looks good, thank you!