gha: add neoeden job to test.yml workflow #1045
Open
+117
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
requested review from
deitch,
eriknordmark,
europaul and
yash-zededa
|
@uncleDecart but do we really need this workflow? I thought that golang tests are just compiled and run with the rest of Eden tests in the regular |
europaul
reviewed
Dec 2, 2024
Comment on lines
64
to
66
| run: cd tests/sec && go test | ||
| shell: bash | ||
| working-directory: "./eden" |
There was a problem hiding this comment.
Suggested change
| run: cd tests/sec && go test | |
| shell: bash | |
| working-directory: "./eden" | |
| run: go test | |
| shell: bash | |
| working-directory: "./eden/tests/sec" |
will it work like this? 🤔 then you don't need to change the directory back
Instead of adding additional workflow to eden, we run neoeden alongside with older version intent is that end user (EVE CI/CD pipeline) will not require any changes, it will still call test.yml there will be an additional test suite. End goal is to gradually move all the test suites to golang-based tests, so at some point smoke tests will be running in neoeden, or networking tests, etc. etc. Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
force-pushed
the
add-neoeden-to-gha
branch
from
13852fd to
9ad0846
Compare
europaul
reviewed
Dec 12, 2024
| artifact_run_id: ${{ inputs.artifact_run_id }} | ||
| require_virtualization: ${{ inputs.require_virtualization }} | ||
| - name: Run security tests | ||
| run: cd tests/sec && go test |
There was a problem hiding this comment.
kudos to @shjala for the following comment:
why don't we put all commands calling the tests in this workflow in a bash script and call that script from here
Advantages:
- you don't need to change GHA every time you add a new test - you add it to that workflow bash script instead
- your newly added tests run immediately on the PR you added them in, because there is no change to the GHA itself
Disadvantages:
- some security concerns about the latter advantage and how people might change the bash script on their PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding additional workflow to eden, we run neoeden alongside with older version intent is that end user (EVE CI/CD pipeline) will not require any changes, it will still call test.yml there will be an additional test suite. End goal is to gradually move all the test suites to golang-based tests, so at some point smoke tests will be running in neoeden, or networking tests, etc. etc.