Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asyncio hlapi double awaitable returns (Fix #19) #24

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

eLvErDe
Copy link

@eLvErDe eLvErDe commented Sep 12, 2023

Commit 67563a1 introduced a bug while converting legacy asyncio API to new "async def" style.

Previous methods where NOT decorated with @asyncio.coroutine and returned a Future object being awaitable.
Updated code still returns a Future object but adds async keyword to function definition leading to awaitable function returning awaitable Future.

That breaks existing API.

eLvErDe and others added 2 commits September 12, 2023 16:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Commit 67563a1 introduced a bug while
converting legacy asyncio API to new "async def" style. Previous methods
where NOT decorated with @asyncio.coroutine and returned a Future object
being awaitable. Updated code still returns a Future object but adds async
keyword to function definition leading to awaitable function returning
awaitable Future. That breaks existing API.
@lextm lextm merged commit 5280c5c into lextudio:main Sep 12, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants