remove zlib build from macos #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure of docker images should be unrelated, right? It seems to be a random timeout. If the removed step has been not working already, the system's zlib was linked? |
|
This only stopped working today because zlib 1.3 is no longer available at the specified url |
|
I see, there is no apple silicon support anyway. |
|
I just noticed that zlib is still referenced here. Will this PR break aarch/arm build? |
|
arm/arm64 uses a different pipeline so that part is not hit on those builds |
|
Now that I think about it, I'm not certain that the macos build isn't using the custom zlib. I can revert this change and fix the zlib download url |
|
Yes, I think it's probably better to revert it, considering we want to compile M1 biniaries in #21. |
bjia56
added a commit
to bjia56/curl-impersonate
that referenced
this pull request
Jan 25, 2024
This reverts commit ecdf1e0.
perklet
pushed a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build doesn't seem to be doing anything anymore. Furthermore, zlib 1.3.1 was just released and the 1.3 source download link is now broken.