refactor: note path iteration

levirs565 · May 26, 2023 · b544f6b · b544f6b
1 parent 7c9746a
commit b544f6b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/src/main.ts b/src/main.ts
@@ -65,13 +65,11 @@ export default class DendronTreePlugin extends Plugin {
   onunload() {}
 
   async createNote(baseName: string) {
-    const path = `${this.settings.vaultPath}/${baseName}.md`;
-    const title = generateNoteTitle(
-      NoteTree.getPathFromFileName(baseName).at(-1)!,
-      isUseTitleCase(baseName)
-    );
+    const filePath = `${this.settings.vaultPath}/${baseName}.md`;
+    const notePath = NoteTree.getPathFromFileName(baseName);
+    const title = generateNoteTitle(notePath[notePath.length - 1], isUseTitleCase(baseName));
     const template = getNoteTemplate(title);
-    return await this.app.vault.create(path, template);
+    return await this.app.vault.create(filePath, template);
   }
 
   async createRootFolder() {

diff --git a/src/note.ts b/src/note.ts
@@ -118,8 +118,7 @@ export class NoteTree {
     let currentNote: Note = this.root;
 
     if (!NoteTree.isRootPath(path))
-      while (path.length > 0) {
-        const name = path.shift()!;
+      for (const name of path) {
         let note: Note | undefined = currentNote.findChildren(name);
 
         if (!note) {
@@ -142,8 +141,7 @@ export class NoteTree {
 
     let currentNote: Note = this.root;
 
-    while (path.length > 0) {
-      const name = path.shift()!;
+    for (const name of path) {
       const found = currentNote.findChildren(name);
       if (!found) return undefined;
       currentNote = found;