Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps/webview to v0.10.0 #9

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rainbyte
Copy link

@rainbyte rainbyte commented Jul 29, 2020

Recently webview/webview was rewritten, and this PR syncs webviewhs with that version.

Interesting changes:

  • Main loop in handled exclusively by webview in an efficient way (avoids high cpu usage).
  • Supports binding multiple callbacks associated to a request id (invoke is now internal).
  • Supports sending back results to frontend in an request-response fashion.

Some things are not supported anymore by upstream, so they were removed:

  • webview_set_fullscreen
  • webview_set_color
  • webview_dialog
  • webview_debug
  • webview_print_log

Those can be implemented in JavaScript or via system specific backends.

It is published as a draft to discuss how to improve implementation.

TODO:

  • Docs: describe how to bind multiple callbacks
  • Docs: describe request-response mechanism
  • Improve inline documentation
  • Port webviewhs/examples
  • Test webviewhs/examples-light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant