[P097] Updating code and (later) documentation #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added extra routine for esp32 s2 and s3 - added option to wake up the esp for supported devices (tested with s3) - added second value "state" for easier handling - failed epically to add a long press event because I am just a simple person, but left the remains for someone else to pick up And as always, please don't stone me. me and c++ are not going to be friends in this life anymore. :) If you agree to the changes i will update the documentatzion accordingly
tonhuisman
reviewed
Nov 18, 2024
tonhuisman
reviewed
Nov 18, 2024
tonhuisman
reviewed
Nov 18, 2024
tonhuisman
reviewed
Nov 18, 2024
tonhuisman
reviewed
Nov 18, 2024
TD-er
reviewed
Nov 18, 2024
That's why a |
- added and tested wakeup on ep32 classic
tonhuisman
reviewed
Nov 19, 2024
get the actual valuename
- added "toggle state" option (since I am not able to add a long press :) )
- added "long press" event - disabled "Single event with all values" since it is not working with the recent code (suggestions are welcome) but there is also the question if it is necessary
TD-er
reviewed
Nov 25, 2024
TD-er
reviewed
Nov 25, 2024
TD-er
reviewed
Nov 27, 2024
TD-er
reviewed
Nov 27, 2024
- make all touch pins available on s2/s3
- check if touchpad exists
TD-er
reviewed
Nov 27, 2024
- reverting T10_to_T14 support
tonhuisman
reviewed
Nov 27, 2024
|
Something still smells fishy with the touch inputs on my S3. When i add and then delete a "touch task" and then hit reboot i get quite often a "Guru Meditation Error" Edit: I'll do more testing to rule out other conditions... |
|
Ok..it happens to other tasks too.. |
|
And what if you copy over the old code of this task to see if your changes made any difference? Does this happen on a SPIFFS build or also on a LittleFS build? (different SDK version) |
- type of threshold now dependent on model (uin32_t for s2 and s3) - max threshold value now also dependent on the type of esp
I tried this on a fresh esp32-s3 with a "normal" build to rule out that my changes have something to do with it.
SPIFFS... didn´t test it with LittleFS. The only usable option right now is |
tonhuisman
reviewed
Nov 28, 2024
| @@ -124,7 +126,7 @@ boolean Plugin_097(uint8_t function, struct EventStruct *event, String& string) | |||
| addFormCheckBox(F("Send Touch Event"), F("sendtouch"), P097_SEND_TOUCH_EVENT); | |||
| addFormCheckBox(F("Send Release Event"), F("sendrelease"), P097_SEND_RELEASE_EVENT); | |||
| addFormCheckBox(F("Send Duration Event"), F("sendduration"), P097_SEND_DURATION_EVENT); | |||
| addFormNumericBox(F("Touch Threshold"), F("threshold"), P097_TOUCH_THRESHOLD, 0, P097_MAX_ADC_VALUE); | |||
| addFormNumericBox(F("Touch Threshold"), F("threshold"), P097_TOUCH_THRESHOLD, 0, P097_MAX_THRESHOLD_VALUE); | |||
There was a problem hiding this comment.
This defined value is only defined for ESP32S2 and ESP32S3... Not sure why the name is changed?
- Hopefully fixed compile errors for non-touch ESP32 variants by standardizing the use of uint32_t for the threshold parameter on ESP32 Classic. The value remains limited by P097_MAX_THRESHOLD_VALUE to 4095.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failed epically to add a long press event because I am just a simple person, but left the remains for someone else to pick uppins 10 to 14 now available for ESP32 s2 and s3they still cause crashesAnd as always, please don't stone me. Me and c++ are not going to be friends in this life anymore. :)
If you agree to the changes i will update the documentation accordingly.