[Controller] Fail gracefully when almost out of memory #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One often reported issue is that the ESPEasy node (especially ESP8266 ones) will crash when WiFi is unstable. This could be due to memory suddenly filling up by the controller queue. When creating a new item for the controller queue, there was no `(std::nothrow)` included on the `new` calls, so if running out of memory this might have thrown a `std::bad_alloc` exception, which are not caught and thus ESPEasy might crash on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One often reported issue is that the ESPEasy node (especially ESP8266 ones) will crash when WiFi is unstable.
This could be due to memory suddenly filling up by the controller queue. When creating a new item for the controller queue, there was no
(std::nothrow)included on thenewcalls, so if running out of memory this might have thrown astd::bad_allocexception, which are not caught and thus ESPEasy might crash on it.Fixes: #4726
Fixes: #3649
Fixes: #2341
Before merge, see: #4770