#145: change nbhttp.Engine.Start order, fix race condition

lesismal · Dec 3, 2021 · ff075ad · ff075ad
1 parent db13c52
commit ff075ad
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/nbhttp/engine.go b/nbhttp/engine.go
@@ -329,12 +329,16 @@ func (e *Engine) stopListeners() {
 
 // Start .
 func (e *Engine) Start() error {
-	err := e.startListeners()
+	err := e.Gopher.Start()
 	if err != nil {
 		return err
 	}
-
-	return e.Gopher.Start()
+	err = e.startListeners()
+	if err != nil {
+		e.Gopher.Stop()
+		return err
+	}
+	return err
 }
 
 // Stop .