Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gin <-> Arpc integration example leveraging webchat #63

Closed
wants to merge 1 commit into from

Conversation

KevM
Copy link

@KevM KevM commented Mar 18, 2024

Closes #62

I took a swing at modifying the existing chat example to be hosted by Gin and add a simple web API exposing the room user identifiers via GET /room

Let me know what you think. I wasn't sure you wanted a dependency on Gin, so I made the example folder it's own go module. If you know a better way, I am happy to oblige.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.11%. Comparing base (802970d) to head (6933ab8).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   64.34%   57.11%   -7.24%     
==========================================
  Files           6        7       +1     
  Lines        1666     1884     +218     
==========================================
+ Hits         1072     1076       +4     
- Misses        550      762     +212     
- Partials       44       46       +2     
Flag Coverage Δ
unittests 57.11% <ø> (-7.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lesismal
Copy link
Owner

arpc core implementation imports std only,the arpc/go.mod only declares the package name but doesn't run go mod tidy to keep the core clean and zero dependencies.
So, please don't generate go.mod and go.sum.

Please don't use too many 3rd libs if not needed, don't commit bin files:
image

@lesismal
Copy link
Owner

I'll close this pr cause the bin file has been in this branch's commit history, reset or re-fork a clean branch will be better.

@lesismal lesismal closed this Mar 19, 2024
@KevM
Copy link
Author

KevM commented Mar 19, 2024

I'm not sure what to do. The example requires Gin. I'll let you do what you want with this.

@lesismal
Copy link
Owner

ok, I'll do it, tks bro!

@KevM KevM mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gin -> ARPC integration
2 participants