fix: handle window case correctly due to this

leshill · Dec 16, 2024 · 7b4c6d6 · 7b4c6d6
1 parent f878eae
commit 7b4c6d6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/lib/handlebars_assets/handlebars_template.rb b/lib/handlebars_assets/handlebars_template.rb
@@ -153,15 +153,15 @@ def compile_default(source)
         unindent <<-PARTIAL
             (function() {
               Handlebars.registerPartial(#{@template_path.name}, #{template});
-            }).call(this);
+            }).call(this || window);
         PARTIAL
       else
         unindent <<-TEMPLATE
             (function() {
               this.#{template_namespace} || (this.#{template_namespace} = {});
               this.#{template_namespace}[#{@template_path.name}] = #{template};
               return this.#{template_namespace}[#{@template_path.name}];
-            }).call(this);
+            }).call(this || window);
         TEMPLATE
       end
     end

diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -25,8 +25,7 @@ module CompilerSupport
 
   def compile_hbs(source)
     compiler_src = Pathname(HandlebarsAssets::Config.compiler_path).join(HandlebarsAssets::Config.compiler).read
-    ExecJS.compile("var window = {}; #{compiler_src}").call('Handlebars.precompile', source,
-                                                            HandlebarsAssets::Config.options)
+    ExecJS.compile("#{compiler_src}").call('Handlebars.precompile', source, HandlebarsAssets::Config.options)
   end
 
   def hbs_compiled(template_name, source)
@@ -38,7 +37,7 @@ def hbs_compiled(template_name, source)
         this.#{template_namespace} || (this.#{template_namespace} = {});
         this.#{template_namespace}[#{template_name.dump}] = Handlebars.template(#{compiled_hbs});
         return this.#{template_namespace}[#{template_name.dump}];
-      }).call(this);
+      }).call(this || window);
     END_EXPECTED
   end
 
@@ -48,7 +47,7 @@ def hbs_compiled_partial(partial_name, source)
     <<~END_EXPECTED
       (function() {
         Handlebars.registerPartial(#{partial_name.dump}, Handlebars.template(#{compiled_hbs}));
-      }).call(this);
+      }).call(this || window);
     END_EXPECTED
   end
 end

diff --git a/vendor/assets/javascripts/handlebars.js b/vendor/assets/javascripts/handlebars.js
@@ -33,7 +33,7 @@ THE SOFTWARE.
 		exports["Handlebars"] = factory();
 	else
 		root["Handlebars"] = factory();
-})(this, function() {
+})(this || window, function() {
 return /******/ (function(modules) { // webpackBootstrap
 /******/ 	// The module cache
 /******/ 	var installedModules = {};

diff --git a/vendor/assets/javascripts/handlebars.runtime.js b/vendor/assets/javascripts/handlebars.runtime.js
@@ -33,7 +33,7 @@ THE SOFTWARE.
 		exports["Handlebars"] = factory();
 	else
 		root["Handlebars"] = factory();
-})(this, function() {
+})(this || window, function() {
 return /******/ (function(modules) { // webpackBootstrap
 /******/ 	// The module cache
 /******/ 	var installedModules = {};