feat(ci): add CI to the project #4
Conversation
* Add GitHub workflow to run `cargo make ci-flow` on push to main and in PRs, * Leverage sensible default from `cargo-make`, * Use the same fmt than the monorepository, * Fix Doc Tests so they compile, * Update dependencies to use latest main until we stabilise, * Reformat the codebase to comply with CI, * Explicitly request `nightly` toolchain. Signed-off-by: Enzo "raskyld" Nocera <[email protected]>
Signed-off-by: Enzo "raskyld" Nocera <[email protected]>
Signed-off-by: Enzo "raskyld" Nocera <[email protected]>
|
cc @ogghead you may wanna have a 👀 on that as well! |
| @@ -0,0 +1,2 @@ | |||
| [toolchain] | |||
| channel = "nightly-2024-11-01" | |||
There was a problem hiding this comment.
Can you elaborate on why nightly is needed? If we need to rely on nightly-only features, my understanding is that would force consumers of this crate to use nightly too. But it is definitely possible that I am overthinking the impact downstream, so curious to hear your thoughts!
There was a problem hiding this comment.
Good question, I think most people will use nightly because of : https://book.leptos.dev/deployment/binary_size.html so they can rebuild the standard library with optimisation, also I did that because the cargo project itself use nightly for its CI, but maybe nightly is not fundamentally needed and once we stabilise the crate we can think about using stable rust
There was a problem hiding this comment.
Fair , there are many optimizations in nightly -- maybe I am overblowing the impact if this crate doesn't use nightly code logic features. Thanks for the explanation
There was a problem hiding this comment.
Oh no I think your concern is valid!
Actually, you should even open an issue so we look back at it once we start stabilizing the crate.
|
Nice, I haven't seen cargo-make before, cool stuff 😄 Thanks for creating this PR! Just had one comment/question on nightly usage, overall lgtm |
|
LOL There's a little bit more to this PR than just a GH action |
|
All looked good to me, thanks for y'alls work on this |
cargo make ci-flowon push to main and in PRs,cargo-make,nightlytoolchain.