Call form execute hook after object update

lepidus · Sep 4, 2024 · 997c7f3 · 997c7f3
1 parent c278e4b
commit 997c7f3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/controllers/grid/catalogEntry/form/IdentificationCodeForm.inc.php b/controllers/grid/catalogEntry/form/IdentificationCodeForm.inc.php
@@ -177,7 +177,6 @@ public function readInputData() {
 	 * @copydoc Form::execute()
 	 */
 	public function execute(...$functionArgs) {
-		parent::execute(...$functionArgs);
 		$identificationCodeDao = DAORegistry::getDAO('IdentificationCodeDAO'); /* @var $identificationCodeDao IdentificationCodeDAO */
 		$publicationFormatDao = DAORegistry::getDAO('PublicationFormatDAO'); /* @var $publicationFormatDao PublicationFormatDAO */
 
@@ -209,6 +208,9 @@ public function execute(...$functionArgs) {
 			$identificationCodeId = $identificationCodeDao->insertObject($identificationCode);
 		}
 
+		// in order to be able to use the hook
+		parent::execute(...$functionArgs);
+
 		return $identificationCodeId;
 	}
 }

diff --git a/controllers/grid/catalogEntry/form/PublicationFormatForm.inc.php b/controllers/grid/catalogEntry/form/PublicationFormatForm.inc.php
@@ -155,8 +155,6 @@ function readInputData() {
 	 * @see Form::execute()
 	 */
 	function execute(...$functionParams) {
-		parent::execute(...$functionParams);
-
 		$publicationFormatDao = DAORegistry::getDAO('PublicationFormatDAO'); /* @var $publicationFormatDao PublicationFormatDAO */
 		$publicationFormat = $this->getPublicationFormat();
 		if (!$publicationFormat) {
@@ -188,6 +186,9 @@ function execute(...$functionParams) {
 			SubmissionLog::logEvent(Application::get()->getRequest(), $this->getMonograph(), SUBMISSION_LOG_PUBLICATION_FORMAT_CREATE, 'submission.event.publicationFormatCreated', array('formatName' => $publicationFormat->getLocalizedName()));
 		}
 
+		// in order to be able to use the hook
+		parent::execute(...$functionParams);
+
 		return $representationId;
 	}
 }

diff --git a/controllers/grid/users/chapter/form/ChapterForm.inc.php b/controllers/grid/users/chapter/form/ChapterForm.inc.php
@@ -198,8 +198,6 @@ function readInputData() {
 	 * @see Form::execute()
 	 */
 	function execute(...$functionParams) {
-		parent::execute(...$functionParams);
-
 		$chapterDao = DAORegistry::getDAO('ChapterDAO'); /* @var $chapterDao ChapterDAO */
 		$chapter = $this->getChapter();
 		$isEdit = !!$chapter;
@@ -238,6 +236,9 @@ function execute(...$functionParams) {
 			DAORegistry::getDAO('SubmissionFileDAO')->updateChapterFiles($selectedFiles, $this->getChapter()->getId());
 		}
 
+		// in order to be able to use the hook
+		parent::execute(...$functionParams);
+
 		return true;
 	}
 }