Pre-created data dir are now created in cache (also, fix option to git clone full data set) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliviaLynn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
(adding Drew for visibility, but please enjoy your time off)
Fixes #78. The code to pre-make data directories before actually downloading the data (to avoid race conditions) was not yet updated to point to our now-default data location. This should also solve the issue of a couple of files not getting downloaded in the first pass, and needing the "retry" to be downloaded again.
Also updates the git clone script for a full-data download. I know we might want to get rid of this completely, but it's nice to have a way to get the entire data set downloaded and placed appropriately with a single line of code, and it should be working now.