Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some headers and message display #263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

olivierilbert
Copy link
Collaborator

Minor improvements for the display:

  • Offsets from auto adapt written twice (once in prep_data, once in zphota.py). Remove one of them.
  • More informative error message when a file is missing
  • Change the header of the ascii file for the predicted magnitude library

@olivierilbert olivierilbert marked this pull request as draft December 19, 2024 10:48
@olivierilbert
Copy link
Collaborator Author

I am going to close issue #261 by Mara and check the few places were we display information using the c++ convention starting indexing at 0, while it would be more clear to start at 1.

@olivierilbert olivierilbert marked this pull request as ready for review December 19, 2024 17:30
@olivierilbert
Copy link
Collaborator Author

Ready to merge in the main, despite this failure in "Unit test and code coverage / build (3.9) (pull_request)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant