Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U/jct/solving valid lib arg issue #257

Closed
wants to merge 10 commits into from

Conversation

johannct
Copy link
Member

  • improve methz treatment
  • continue to improve code readability around validLib
  • change use of closest_red in fitIR : it should use consiz

@johannct johannct self-assigned this Dec 16, 2024
Copy link
Collaborator

@olivierilbert olivierilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that some changes were already merged in 254-zfix=yes-too-slow.
they are fine too me.
In the context in which flux_rescaling is called, better to use the name mass_rescaling.

@johannct johannct closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants