Moving C++ code to new repo #1
Conversation
drewoldag
requested review from
johannct,
raphaelshirley and
OliviaLynn
and removed request for
johannct,
raphaelshirley and
OliviaLynn
|
I successfully built on my mac. There was one warning which is present on the original make too. cmake failed due to pybind missing as possibly expected. This branch can be merged to main in my opinion. |
|
Makefile runs make to completion but creates the bin/ directory with the executables under src/ not under the root dir. This is clearly related to having moved the source code one level down in path without modifying the Makefile. Is this by design or by overlook? |
|
@johannct That was an oversight. I'll fix that when I get to my desk! |
|
This looks good and builds for me on NERSC so far |
…p level `bin` directory.
…lephare into awo/add-c-code
|
Alright folks, I've addressed the comment about the location of bin directory. I've updated |
* WIP - adding c code. Running `make` seems to work correctly. * fix a trivial warning left over from gitlab * Updating Makefile and gitignore so that binary files are placed in top level `bin` directory. --------- Co-authored-by: Johann Cohen-Tanugi <[email protected]>
Change Description
Pulling in the C++ code form the original LePhare repository into the new. Moved to a slightly new location:
.../source/*.cpp->.../src/lib/*cppThis PR also includes the top level CMakeLists.txt file as well as some of the .gitignore file contents.