salim+18 and README_full #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
olivierilbert
commented
Jun 27, 2024
olivierilbert
commented
- Include a new attenuation curve from Salim+18
- Update the README_full in the directory examples to use this attenuation curve, and improve the comments for the documentation
…ull from examples
raphaelshirley
approved these changes
Jun 28, 2024
| export LEPHAREDIR='/home/oilbert/LEPHARE/' | ||
| # Where to store the libraries (if not created with the make file, you must have a $LEPHAREWORK/filt, $LEPHAREWORK/lib_bin, $LEPHAREWORK/lib_mag | ||
| # Indicate the directory containing all the LePHARE data, as the templates/filters/attenutation | ||
| export LEPHAREDIR='/Users/ilbert/LEPHARE-data/' |
There was a problem hiding this comment.
I guess this could be relative to make it run on any system but it is clear this needs to be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.