feat(package/weather): Version 1.0 of weather package #108
Conversation
|
Hello @Imperator26, Thanks for opening this PR and for that work! I'll take a look at it later. Let's see how we can deal with both of these packages #103. Also, today I've created a Discord so that we can discuss further, feel free to join it. |
| @@ -8,5 +8,7 @@ requests = "==2.21.0" | |||
| pytube = "==9.5.0" | |||
| tinydb = "==3.9.0" | |||
| beautifulsoup4 = "==4.7.1" | |||
| pyowm = "==2.10.0" | |||
There was a problem hiding this comment.
This PR is quite old, before we merge, we should use the latest versions of the dependencies used in this package.
Currently the latest version of pyowm is 3.2.0 and tzlocal is 2.1.0.
There was a problem hiding this comment.
Thanks for your contribution! @facorazza
I submit several comments about your code, feel free to discuss.
Also there isn't automated tests for this package, we should add some.
| from pyowm import OWM | ||
|
|
||
|
|
||
| # Decorators |
There was a problem hiding this comment.
We should avoid "useless" comments.
| return wrapper_acquire_weather | ||
|
|
||
|
|
||
| # Methods |
There was a problem hiding this comment.
Same here, we should avoid that sort of comment.
| @@ -0,0 +1 @@ | |||
| 1.0.3 | |||
There was a problem hiding this comment.
I guess it is still the first version (1.0.0) of the package until it has been merged into develop.
| - [PyOWM GitHub](https://github.com/csparpa/pyowm) | ||
| - [PyOWM Docs](https://pyowm.readthedocs.io/en/latest/) | ||
|
|
||
| #### TODO |
There was a problem hiding this comment.
We should not use "Todo" inside markdown files, instead it would be GitHub issues or Trello Card.
What do you think?
| Get when the sun rises. | ||
| """ | ||
|
|
||
| dt = payload["wtr"].get_sunrise_time("date") |
There was a problem hiding this comment.
We should avoid abbreviations in variable names.
So instead to call it dt, we could call it date_time for example.
What type of change does this PR introduce?
Does this PR introduce breaking changes?
List any relevant issue numbers:
#105
Description:
New weather package.