Fix getExtensionPageUrl on Windows (#1609)

* Fix getExtensionPageUrl on Windows Signed-off-by: Lauri Nevala <[email protected]> * Use path.posix.join() instead Signed-off-by: Lauri Nevala <[email protected]> * Fix lint issues Signed-off-by: Lauri Nevala <[email protected]>
lensapp · Dec 2, 2020 · 57d6dfa · 57d6dfa
1 parent c22d569
commit 57d6dfa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/src/extensions/registries/page-registry.ts b/src/extensions/registries/page-registry.ts
@@ -44,7 +44,7 @@ export function getExtensionPageUrl<P extends object>({ extensionId, pageId = ""
   const extensionBaseUrl = compile(`/extension/:name`)({
     name: sanitizeExtensionName(extensionId), // compile only with extension-id first and define base path
   });
-  const extPageRoutePath = path.join(extensionBaseUrl, pageId); // page-id might contain route :param-s, so don't compile yet
+  const extPageRoutePath = path.posix.join(extensionBaseUrl, pageId);
 
   if (params) {
     return compile(extPageRoutePath)(params); // might throw error when required params not passed

diff --git a/webpack.extensions.ts b/webpack.extensions.ts
@@ -6,6 +6,7 @@ import { sassCommonVars } from "./src/common/vars";
 export default function (): webpack.Configuration {
   const entry = "./src/extensions/extension-api.ts";
   const outDir = "./src/extensions/npm/extensions/dist";
+
   return {
     // Compile for Electron for renderer process
     // see <https://webpack.js.org/configuration/target/>

diff --git a/webpack.main.ts b/webpack.main.ts
@@ -8,6 +8,7 @@ import * as vars from "./src/common/vars";
 
 export default function (): webpack.Configuration {
   console.info("WEBPACK:main", vars);
+
   return {
     context: __dirname,
     target: "electron-main",

diff --git a/webpack.renderer.ts b/webpack.renderer.ts
@@ -17,6 +17,7 @@ export function webpackLensRenderer({ showVars = true } = {}): webpack.Configura
   if (showVars) {
     console.info("WEBPACK:renderer", vars);
   }
+
   return {
     context: __dirname,
     target: "electron-renderer",