Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 remove charset from http request headers when the body is in bytes #508

Merged
merged 5 commits into from
Oct 7, 2023
Merged

🐛 remove charset from http request headers when the body is in bytes #508

merged 5 commits into from
Oct 7, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Oct 6, 2023

Fixes #505

@techouse techouse added the bug Something isn't working label Oct 6, 2023
@techouse techouse mentioned this pull request Oct 6, 2023
Closed
@techouse techouse marked this pull request as draft October 7, 2023 06:57
@techouse
Copy link
Collaborator Author

techouse commented Oct 7, 2023

I'll add some tests first.

@JEuler
Copy link
Collaborator

JEuler commented Oct 7, 2023

Hooray! :)

@techouse techouse marked this pull request as ready for review October 7, 2023 07:38
@techouse techouse merged commit b48066d into lejard-h:develop Oct 7, 2023
3 of 4 checks passed
@techouse techouse deleted the fix/505-http-headers-with-binary-data branch October 7, 2023 07:40
techouse added a commit that referenced this pull request Oct 7, 2023
@techouse
🔖 release chopper v7.0.7 and chopper_generator v7.0.5
8785404 
# chopper

## 7.0.7

- #508

# chopper_generator

## 7.0.5

- #507
@techouse techouse mentioned this pull request Oct 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEuler JEuler JEuler approved these changes

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

@meysam1717 meysam1717 Awaiting requested review from meysam1717 meysam1717 is a code owner

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@JEuler JEuler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Change auto generate header from http
2 participants
@techouse @JEuler