Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ot singlet compatibility [MEDIUM] #144

Closed

Conversation

daknuett
Copy link
Contributor

  • ot_singlet was vastly incompatible with other ots.
  • For future work on ot embeddings all ots must be treated consistently.

This pullrequest changes the following:

  • ot_singlet is instantiated like all ots now.
  • ot_singlet and subclasses are singletons now.
  • value.otype == g.ot_singlet and value.otype.data_otype() == g.ot_singlet continue working as before.

@daknuett
Copy link
Contributor Author

The new changes provide lattice.otype.is_singlet which is True for ot_singlet and all derived classes, and False for all other classes, including ot_base.

@lehner
Copy link
Owner

lehner commented Mar 23, 2024

Closing this since it should be contained in discussed improvements of type system.

@lehner lehner closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants