Skip to content

Commit

Permalink
initial changes to work with new form of linkout urls
Browse files Browse the repository at this point in the history
  • Loading branch information
adf-ncgr committed May 26, 2023
1 parent 8da2093 commit 8f0939f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/app/gene/services/gene.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ export class GeneService extends HttpService {
// fetches source specific details for the given gene
getGeneDetails(gene: string, source: string): Observable<any> {
const request = this._appConfig.getServerRequest(source, 'geneLinks');
const makeUrl = (url: string) => url + gene + '/json';
//TODO: make this more configurable via template substitution
const makeUrl = (url: string) => url + gene;
return this._makeHttpRequest<any>(request, {}, makeUrl);
}

Expand Down
3 changes: 2 additions & 1 deletion src/app/gene/services/region.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ export class RegionService extends HttpService {
// fetches source specific details for the given region
getRegionDetails(chromosome: string, start: number, end: number, source: string): Observable<any> {
const request = this._appConfig.getServerRequest(source, 'regionLinks');
const makeUrl = (url: string) => url + chromosome + '&start=' + start + '&end=' + end ;
//TODO: make this more configurable via template-based substitution
const makeUrl = (url: string) => url + chromosome + ':' + start + '-' + end ;
return this._makeHttpRequest<any>(request, {}, makeUrl);
}

Expand Down

0 comments on commit 8f0939f

Please sign in to comment.