Don’t base64-decode when there’s nothing to decode #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Servers are free to return the string “=” instead of actual base64 data in the success message payload as per [1] (cf. [2]). Prosody does this as of v0.10. Hence, despite login success, we choke when trying to base64-decode non-base64 data and get stuck after auth. We avoid getting stuck by making sure the data is not just nil but also not a void “=”. [1] <http://xmpp.org/rfcs/rfc6120.html#sasl-process-neg-initiate> [2] <https://prosody.im/issues/issue/729> Fixes legoscia#19
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers are free to return the string “=” instead of actual base64 data in the
success message payload as per [1] (cf. [2]). Prosody does this as of v0.10.
Hence, despite login success, we choke when trying to base64-decode non-base64
data and get stuck after auth.
We avoid getting stuck by making sure the data is not just nil but also not a
void “=”.
[1] http://xmpp.org/rfcs/rfc6120.html#sasl-process-neg-initiate
[2] https://prosody.im/issues/issue/729
Fixes #19