-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Modifier #23
Default Modifier #23
Conversation
Ill give this a test asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not enough time to fix the broken test rn, maybe later tonight. |
@VuiMuich No problem, I'll check right away what is wrong with the CI processes and do some push to fix it |
Thanks for returning to this PR so promptly after that long time 😃 Nice idea to generate the normalized command from the raw string. If you have a minute to |
Of course, now I try to be more attentive to all this, I will be reviewing the project to see if I can find more I can collaborate.
Oh no, I could have sworn I ran the corresponding commands before pushing, I'll fix it right away, thank you very much |
Thanks for your contribution. If you have more to come this is surely welcome. Hopefully we don't have you waiting for the merge for so long again. |
Create a new default modifier param and make keybind modifier optional, based on #9
Create test for the new parser of config