-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] make modifier
field optional
#9
Comments
What do you think about having a default_modifier as a parameter in the configuration and only use it when no modifier is assigned to the keybind? |
That would make it impossible to assign keybinds like Brightness buttons etc. to work without the need of a modifier. |
I was trying to make a contribution with the idea that I gave you, here I leave it more exemplified, although I would like you to explain me better your idea, it sounds great and maybe I can contribute in some way. Config(
default_modifier: ["Mod4", "Shift"],
keybinds: [
Keybind(
command: Execute("st -e htop"),
key: Key("x"),
),
Keybind(
command: Executes(["st -e htop", "st -e bpytop"]),
key: Keys(["x", "m"]),
),
Keybind(
command: Chord([
Keybind(
command: Execute("st -e htop"),
modifier: Some(["Mod4"]),
key: Key("c"),
),
]),
modifier: Some(["Mod4"]),
key: Key("c"),
),
]
) |
.. so it isn't necessary anymore to have awkward empty values in the config.
The text was updated successfully, but these errors were encountered: