Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default variables in c headers #478

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Remove default variables in c headers #478

merged 3 commits into from
Nov 24, 2024
+34 −22

Conversation

stduhpf
Copy link
Contributor

@stduhpf stduhpf commented Nov 23, 2024

Fixes: #477

@stduhpf
Copy link
Contributor Author

stduhpf commented Nov 23, 2024

Hijacking this pr to also make the default slg scale to 0.

@SkutteOleg
Copy link
Contributor

std::vector is not a thing in C as far as I'm aware 🤔

@stduhpf
Copy link
Contributor Author

stduhpf commented Nov 23, 2024

Damn you're right.

@stduhpf stduhpf marked this pull request as draft November 23, 2024 15:56
@stduhpf
Copy link
Contributor Author

stduhpf commented Nov 23, 2024

I'll change it to a C array later.

@stduhpf stduhpf marked this pull request as ready for review November 23, 2024 17:32
@leejet leejet merged commit 53b415f into leejet:master Nov 24, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use STL containers in DLL interface
3 participants
@stduhpf @SkutteOleg @leejet