Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the class ContainerStats is using one thread per container.
When we create the threads we wait for the first docker stats api call to return, so the more container we have the longer it takes to start all the thread, also this becomes inefficient as if you have 100+ containers te docker daemon starts to timeout as it can't handle the load generated by all those threads.
That's why I decided to change it to use a certain number of workers ( 5 by default) which you can configure with the RateLimit key in the config.
This is probably not an ideal fix but at least we are getting the data in a more reliable way without generating too much load on the docker daemon.
Ideally we want docker to create one endpoint to get the stats of all running container as described here moby/moby#22052
@lebauce