feat: btc to sbtc swap #5997
Merged
feat: btc to sbtc swap #5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
feat/btc-sbtc-swap
branch
from
08c6808 to
f5260a2
Compare
fbwoolf
force-pushed
the
feat/display-sbtc
branch
from
a72120a to
dff2e4f
Compare
fbwoolf
force-pushed
the
feat/btc-sbtc-swap
branch
from
f5260a2 to
23d1e16
Compare
kyranjamie
approved these changes
Dec 4, 2024
kyranjamie
reviewed
Dec 4, 2024
| const bitcoinMarketData = useCryptoCurrencyMarketDataMeanAverage('BTC'); | ||
| return { | ||
| balance: balance.availableBalance, | ||
| currency: 'token-btc' as Currency, |
There was a problem hiding this comment.
Suggested change
| currency: 'token-btc' as Currency, | |
| currency: 'token-btc' satisfies Currency, |
?
There was a problem hiding this comment.
Actually, I can remove this, thx. I don't love this type bc confusing. We are using bitflow sdk and still alex for price data.
fbwoolf
force-pushed
the
feat/btc-sbtc-swap
branch
from
23d1e16 to
e66dc21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the BTC to sBTC bridge working in our swaps UI. It is a working version of adding the assets to our current swaps list. I think we can likely handle this a bit better, but I wanted to get up a draft up so we can integrate it with the deposit tx once we get it working. This is branched off that wip POC.
sbtc-draft.mov