feat: add cancel transaction, ref #LEA-958

[alter-eggo]

Try out Leather build 53a7e31 — Extension build, Test report, Storybook, Chromatic

This pr adds option to cancel stx transaction, also adds tests for increase and cancel stx transaction

@Aman-zishan thanks a lot for your work on this

[linear]

LEA-958 Add option to cancel pending transaction

[fbwoolf]

Maybe pull this out as a defined type and use increase-fee?

[alter-eggo]

added enum

[pete-watters]

This code looks good but I am confused about how to cancel a transaction.

I tried to cancel a stacks transfer and I see this:

Do I need to choose a fee and then submit to cancel? 🤔 So you make a new reversed transaction?

[pete-watters]

👍

[alter-eggo]

@314159265359879 could you test this build please

[alter-eggo]

@pete-watters yeah, as I understand you need to increase fee a bit to cancel tx

[314159265359879]

Thanks for this @alter-eggo
The prefilled fee here should default to 0.000001 STX more than the current fee for the transaction being replaced. That way the user can already click submit (now it is not allowed unless they click atleast 2x, which will be excessive in most cases).
With a 0.000001 STX increase the "submit" button can be light up right away (ready to click, and then increasing the fee further is optional).

For context, STX transfers don't usually need a higher fee to get included in a block (unlike some contract calls and contract deployments) they require very little of the "block space".

With the change above. I opt to remove "A higher fee can help replace the old transaction." from the explainer. Because in most cases we'll set the right fee (just 0.000001 STX more then current). Leaving it in there may make users think that they have to set a much higher fee, which is not actually the case. There is always still a chance the old transaction gets processed anyway, because it reaches a miner first or before it is replaced by the new transaction with the higher fee.

"To cancel the transaction we replace it with a minimal STX transfer." Could be a good add here so users are not surprised that the "cancelled" transaction goes away and a small STX transfer is displayed in its place.

I think this is out of scope now: Later we can create an enhancement to label the transaction differently (based on the memo) used in the cancel transaction. "Pending Cancellation" instead of the normal "Pending".

[314159265359879]

See comments above.

[alter-eggo]

thanks @314159265359879 fixed this

[314159265359879]

Looking great!