Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: contractid missing #5915

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: contractid missing #5915

merged 2 commits into from
Oct 23, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Oct 23, 2024 •
edited by leather-bot
Loading

Try out Leather build 4e1ec96 — Extension build, Test report, Storybook, Chromatic

This change broke all SIP10 forms. 7d3ac6f#diff-7620886f3b9dc4af6126a2b98975b1b487047645f49f114c9e4c283513911d6dL35

@alter-eggo please follow up with a test for this please

@kyranjamie kyranjamie force-pushed the fix/urgent-sip-10-issue branch from 67e21b6 to 4e1ec96 Compare October 23, 2024 12:07
@kyranjamie kyranjamie added this pull request to the merge queue Oct 23, 2024
Merged via the queue into dev with commit c91f99d Oct 23, 2024
32 checks passed
@kyranjamie kyranjamie deleted the fix/urgent-sip-10-issue branch October 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alter-eggo alter-eggo alter-eggo approved these changes

@pete-watters pete-watters Awaiting requested review from pete-watters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyranjamie @alter-eggo