feat: add option to hide balance, closes leather-io#5096 #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
force-pushed
the
feat/hide-balance
branch
from
57ee6b0 to
07ecad7
Compare
|
lgtm (except type error) |
pete-watters
force-pushed
the
feat/hide-balance
branch
2 times, most recently
from
8d4b1cd to
cd9192f
Compare
pete-watters
force-pushed
the
feat/hide-balance
branch
from
cd9192f to
d2599ab
Compare
|
@pete-watters is this ready to merge from a code-review perspective? I've assigned @fabric-8 for a final design review. |
|
@markmhendrickson , this is ready to go codewise and @mica000 has already done a design QA in the original contributor PR - #5830 . That's blocked from merge until we can fix the CI issue we face right now. I'll close this PR to avoid confusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a clone of #5830
Demo here:
toggle-privacy.mp4