-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Cancel STX transactions #5533
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import type { StacksNetwork } from '@stacks/network'; | ||
import { ChainID } from '@stacks/transactions'; | ||
|
||
export function getBurnAddress(network: StacksNetwork): string { | ||
switch (network.chainId) { | ||
case ChainID.Mainnet: | ||
return 'SP00000000000003SCNSJTCSE62ZF4MSE'; | ||
case ChainID.Testnet: | ||
return 'ST000000000000000000002AMW42H'; | ||
default: | ||
return 'ST000000000000000000002AMW42H'; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 0 additions & 38 deletions
38
src/app/components/stacks-transaction-item/increase-fee-button.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/app/components/stacks-transaction-item/transaction-action-button.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { IconButton } from '@leather.io/ui'; | ||
|
||
import { BasicTooltip } from '@app/ui/components/tooltip/basic-tooltip'; | ||
|
||
interface ActionButtonProps { | ||
icon: React.ReactElement; | ||
isEnabled?: boolean; | ||
isSelected: boolean; | ||
label: string; | ||
onButtonClick(): void; | ||
} | ||
|
||
export function TransactionActionIconButton(props: ActionButtonProps) { | ||
const { isEnabled, isSelected, onButtonClick, label, icon } = props; | ||
const isActive = isEnabled && !isSelected; | ||
|
||
if (!isActive) return null; | ||
|
||
return ( | ||
<BasicTooltip label={label} side="top"> | ||
<IconButton | ||
icon={icon} | ||
backgroundColor={'ink.background-primary'} | ||
onClick={e => { | ||
e.stopPropagation(); | ||
onButtonClick(); | ||
}} | ||
></IconButton> | ||
</BasicTooltip> | ||
); | ||
} |
138 changes: 0 additions & 138 deletions
138
src/app/features/dialogs/increase-fee-dialog/increase-stx-fee-dialog.tsx
This file was deleted.
Oops, something went wrong.
18 changes: 18 additions & 0 deletions
18
src/app/features/dialogs/transaction-action-dialog/cancel-stx-transaction-dialog.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { RouteUrls } from '@shared/route-urls'; | ||
|
||
import { IncreaseFeeField } from './components/increase-fee-field'; | ||
import { useStxCancelTransaction } from './hooks/use-stx-cancel-transaction'; | ||
import { StxTransactionActionDialog } from './stx-transaction-action-dialog'; | ||
|
||
export function CancelStxTransactionDialog() { | ||
return ( | ||
<StxTransactionActionDialog | ||
title="Cancel transaction" | ||
description="Cancelling a transaction isn't guaranteed to work. A higher fee can help replace the old transaction." | ||
routeUrl={RouteUrls.CancelStxTransaction} | ||
useActionHook={useStxCancelTransaction} | ||
FeeComponent={IncreaseFeeField} | ||
isCancel={true} | ||
/> | ||
); | ||
} |
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the default case in
getBurnAddress
.The function returns the Testnet burn address as the default. It might be clearer to either handle this explicitly or add a comment explaining why this is the default behavior, to avoid confusion in environments where the chain ID might not be explicitly set.
Committable suggestion