Reset to mainnet on signout #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
reviewed
Apr 24, 2024
pete-watters
force-pushed
the
fix/5239/reset-to-mainnet-on-signout
branch
from
8f5f630 to
4c24a32
Compare
pete-watters
changed the title
fbwoolf
approved these changes
Apr 24, 2024
kyranjamie
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix that re-sets the network to
mainneton sign out.I also added another fix to how we are adding some dialogs to the VDOM.
I noticed that we were calling hooks in the settings menu dialogs whenever the parent is rendered and even if they aren't visible. This is a bad problem as was adding to our API requests to
networkun-necessarily.