-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tsconfig update for tokens pkg #5227
Conversation
3f09646
to
feb5da8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!pnpm-lock.yaml
Files selected for processing (3)
- package.json (1 hunks)
- theme/typography.ts (1 hunks)
- tsconfig.json (1 hunks)
Files skipped from review due to trivial changes (1)
- package.json
Additional comments not posted (4)
theme/typography.ts (2)
1-1
: Updated import statement aligns with the new focus on web-specific typography.
5-5
: Correct usage ofgetWebTextVariants
in defining text styles.tsconfig.json (2)
4-4
: Change inmodule
setting to"preserve"
should help maintain module syntax during compilation. Ensure to verify its impact on the build process.
5-5
: Change inmoduleResolution
to"Bundler"
aims to enhance compatibility with specific bundlers. Verify compatibility with the project's bundler setup.
WalkthroughThe recent updates encompass a version increment for a dependency, TypeScript configuration adjustments, and a refinement in typography function usage. These changes aim to improve module management, update dependencies, and enhance text styling capabilities within the project. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
feb5da8
to
b69fb7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!pnpm-lock.yaml
Files selected for processing (3)
- package.json (1 hunks)
- theme/typography.ts (1 hunks)
- tsconfig.json (1 hunks)
Files skipped from review due to trivial changes (2)
- package.json
- tsconfig.json
Additional comments not posted (2)
theme/typography.ts (2)
1-1
: Correctly updated import to usegetWebTextVariants
.
5-5
: Usage ofgetWebTextVariants
indefineTextStyles
is consistent with the new import.Verification successful
The
textStyles
constant is correctly imported and integrated within thetheme
configuration inpanda.config.ts
. This confirms that the usage ofgetWebTextVariants
indefineTextStyles
is consistent and properly integrated.
panda.config.ts
:textStyles
is included in thetheme
configuration.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of `textStyles` with other components. # Test: Search for usage of `textStyles`. Expect: Proper integration without issues. rg --type typescript $'textStyles'Length of output: 68
Script:
#!/bin/bash # Description: Verify integration of `textStyles` with other components. # Test: Search for usage of `textStyles`. Expect: Proper integration without issues. rg 'textStyles'Length of output: 355
Script:
#!/bin/bash # Description: Extract lines from `panda.config.ts` to review the usage of `textStyles`. # Extract lines containing `textStyles` and their surrounding context for review. rg -A 5 -B 5 'textStyles' panda.config.tsLength of output: 667
Updates token package, which required some changes to the tsconfig settings for it to be able to find the declaration files
Summary by CodeRabbit
Chores
Refactor
Configuration Changes