fix: wrong send stx validation msg #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
fix/send-stx-validation-msg
branch
from
a17e552 to
926a90b
Compare
|
Going to merge this bc just fixes a test I need for the release. |
auto-merge was automatically disabled
March 27, 2024 18:47
Pull request was converted to draft
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a flaky test from the validation error msg being wrong on the STX amount input field. I think changing the max length exposed it. It used to say
Cannot not determine decimal precisionbc we weren't passing the Money object to the validator to know the STX decimals.Fixed...
